Add African pidgin language translation #3156
Conversation
… added all best practices in pidgin language
LizzyOrji123
temporarily deployed
to
Pages Preview
GitHub Actions
Inactive
|
If you speak pidgin and would love to contribute to the pidgin open-source guide on Github. I would appreciate your help. |
LizzyOrji123
temporarily deployed
to
Pages Preview
GitHub Actions
Inactive
LizzyOrji123
temporarily deployed
to
Pages Preview
GitHub Actions
Inactive
There was a problem hiding this comment.
Hi, thank you for the PR! I am happy to see this language get added. There are a few changes it needs before we can merge though.
- The directory should be called
pcminstead ofpidgin, this is the ISO designation for the language: https://iso639-3.sil.org/code/pcm - Please rename the language file in the
_datadirectory to bepcm.ymland change thelocale_name - Add the rest of the untranslated pages into the
pcmdirectory as copies from the English version.
ahpook
changed the title
|
@LizzyOrji123 Hi, are you still interested in making this contribution? I left a review with a few requested changes - I'd love to get this merged! Please take a look. |
LizzyOrji123
temporarily deployed
to
Pages Preview
GitHub Actions
Inactive
LizzyOrji123
temporarily deployed
to
Pages Preview
GitHub Actions
Inactive
I have made the corrections. Thank you for being so patient and detailed with your work. |
There was a problem hiding this comment.
Looks great @LizzyOrji123 ! Thanks so much. I made a couple of small suggestions in code review so that the metadata will work with the site generator - I think once those changes are in we'll be good to merge!
Fixing up the metadata
- Markdown style wants `*` not `-` for lists
- Removed some extra blank lines
- The `retext-repeated-words` plugin has only a small list of
words that are allowed to be repeated, but pidgin uses doubled
words as intensifiers ("small small" for "very small"). I added
hyphens ("small-small") because I saw some examples of that
- Renamed the `best-practice.md` -> `best-practices.md` to match
the rest of the site
- Copied the untranslated articles in so the site build works
- The missing `index.html` in this directory was preventing the site build from completely working - Renamed Internal anchor links like `#sabi-to-say-no` to match the new section header names - I'd blithely copied the untranslated files in but not changed their front matter to match the directory name
Weird, this one didn't come up locally
|
Very happy to get this merged in. This is now LIVE on the site! You can see it here |
I created a new language called pidgin and created best-practice.md and other files.
The goal of my branch is to encourage Africans to join the open source community by writing in a language every African can understand which is Pidgin. I would love to recreate the entire guidelines in Pidgin. Thank you.… added all best practices in pidgin language
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.